search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 40 forks source link

ETau FR modules and model #10

Closed cardinia closed 2 years ago

cardinia commented 3 years ago

Unfortunately I had to manually prepare the commits from my master branch, losing the history of the previous commits which can be found on the dev branch of my repository till this commit https://github.com/cardinia/TauFW/commit/44f6585987dacdd82b08e42568b62e17d0775edb Please let me know if any change is required @IzaakWN

cardinia commented 3 years ago

PR finalized and ready for review @IzaakWN

IzaakWN commented 3 years ago

Can you add correctionlib/JSON scripts to Fitter/ETauFR/correctionlib, please? E.g.: https://github.com/cms-tau-pog/TauFW/tree/master/Fitter/TauES/correctionlib

IzaakWN commented 3 years ago

Besides missing correctionlib scripts, everything seems to look fine.

Only small style comment; at some point we should also move from Fitter/ETauFR/Plotter/PlotShapes.C to the central plotting tools in Plotter/python/plot.py, to get a uniform plotting style. See for example Fitter/paper/plotpostfit.py and Fitter/python/plot/postfit.py

IzaakWN commented 2 years ago

@cardinia, is this ready to be merged?

cardinia commented 2 years ago

@cardinia, is this ready to be merged?

Yes, I left some of the older C++ code for cross-checks and left instructions in the README on what methods are deprecated.

cardinia commented 2 years ago

Looks good! Thanks for the READMEs!

Just as a note for the future: we should consider accumulating some general models like Fitter/python/ETauFR/zttmodels.py in Fitter/python/models instead, e.g. some useful variations of tag-and-probe, see https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/102x/python/TagAndProbeModel.py

Completely agree, I think this would be good once we have all different measurements implemented