search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 40 forks source link

Dev jet to tau fake #24

Closed kchrisucy closed 1 year ago

kchrisucy commented 2 years ago

Dear all,

This is the first pull request to cms-tau-pog/TauFW/master of my studies related to Jet to Tau Fake Rate measurements. It includes an initial set of analyzers, tools and plotting scripts.

Best regards, Konstantinos Christoforou

IzaakWN commented 1 year ago

Hi @kchrisucy,

Apologies for the late reply, but could you create a new branch with the commits except for the PicoProducer/config/config.json and .gitignore, and open a new PR, please? These are supposed to be user-specific. If we merge this, it will overwrite other people's config files.

Izaak

kchrisucy commented 1 year ago

Hi and thanks for your reply,

I get that but I'd just added a line in .gitignore for plots that will be produced under JetToTauFR just like Plotter/plots. Regarding PicoProducer/config/config.json, I added the UL versions of the samples*.py, which I thought it will be useful for everyone.

Please let me know if you still believe that I really need to remove these changes from the PR.

Cheers, Konstantinos Christoforou

IzaakWN commented 1 year ago

Yes, but in both cases, if other users pull these commits, it will overwrite those files and they will lose their own configurations, even if you reset it to the default in the current master with a new commit. So it's safer to open a new branch where you have never touched config.json or .gitignore. Sorry for the hassle. We are thinking of a way to protect config.json, because it's not the first time someone adds it to a PR.

kchrisucy commented 1 year ago

Okay, thanks for clarifying!