search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 41 forks source link

WIP: Added possibility to apply selection before computing sumweights; thi… #45

Closed smonig closed 10 months ago

smonig commented 12 months ago

…s allows to remove hard-coded skimming efficiency per jet multiplicity in stitching function

cardinia commented 12 months ago

It looks ok, as a workflow. It might be more efficient to open the cutflow once and update all relevant bins. Right now the update of a single bin corresponds to a loop over all files and scales badly with the number of bins to update. It might be best to have a dictionary between the bin to update and the selection, so that at each opened file, all entries in the dictionary are updated and then the cutflow is updated once.

smonig commented 12 months ago

It looks ok, as a workflow. It might be more efficient to open the cutflow once and update all relevant bins. Right now the update of a single bin corresponds to a loop over all files and scales badly with the number of bins to update. It might be best to have a dictionary between the bin to update and the selection, so that at each opened file, all entries in the dictionary are updated and then the cutflow is updated once.

Hi @cardinia , thanks; I have changed this now. I did not check it, if there is a nTuples with a cutflow somewhere, I can debug.

cardinia commented 11 months ago

As soon as I merge the Run 3 code we can test