search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 41 forks source link

Hackathon: RDataFrame + Tutorial #59

Closed IzaakWN closed 7 months ago

IzaakWN commented 7 months ago

This is to merge the changes from the hackathon branch into the master branch:

These are the changes during the hackathon (after the RDataFrame PR): https://github.com/cms-tau-pog/TauFW/compare/a38324a..1ac569e https://github.com/cms-tau-pog/TauFW/compare/hackathon..1ac569e

IzaakWN commented 7 months ago

@pmastrap @cardinia if there are now further comments, I'll merge this by tomorrow (Wed.) or so?

pmastrap commented 7 months ago

@pmastrap @cardinia if there are now further comments, I'll merge this by tomorrow (Wed.) or so?

Good to go for me, we tested all these changes during Hackathon

IzaakWN commented 7 months ago

@pmastrap I added placeholders for muon SFs, since none are available yet as far as I can see: https://twiki.cern.ch/twiki/bin/view/CMS/MuonRun3_2023

Once we have 2023 samples, we can also compute PU profiles from MC. https://github.com/cms-tau-pog/TauFW/wiki/PicoProducer-corrections#pileup-reweighting

I'll do correctionlib later to avoid potentially introducing new issues, and ROOT files still work fine.

pmastrap commented 7 months ago

@pmastrap I added placeholders for muon SFs, since none are available yet as far as I can see: https://twiki.cern.ch/twiki/bin/view/CMS/MuonRun3_2023

Once we have 2023 samples, we can also compute PU profiles from MC. https://github.com/cms-tau-pog/TauFW/wiki/PicoProducer-corrections#pileup-reweighting

I'll do correctionlib later to avoid potentially introducing new issues, and ROOT files still work fine.

Thanks @IzaakWN ! Works for me. I've added in PicoProducer the config for 2023 (n.b. not all samples are yet available) and, regarding UL instead, the config for 2017/2016 for running on tauPOG privately produced nano with deepTau 2.5. Consequently I've updated the sample_v10.py in Plotter.

pmastrap commented 7 months ago

Just added the json and era configuration for 2023 + some other minor changes

cardinia commented 7 months ago

Hello @IzaakWN @pmastrap , I just finished reviewing everything. I'm fine with merging, thanks for the hard work