search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 41 forks source link

Fix `self.ismutau` vs. `isMuTau` & jet veto requirement for Run 2 #68

Closed IzaakWN closed 5 months ago

IzaakWN commented 5 months ago

Hi @pmastrap & @saswatinandan, can you have a look and sign off before I merge, please? To address some bugs reported for the tutorial using UL2018 I changed

saswatinandan commented 5 months ago

@IzaakWN , at a first glance, it looks fine to me. I am sorry that I didn't take care of Run2 data properly for jetvetomaptool!

IzaakWN commented 5 months ago

@IzaakWN , at a first glance, it looks fine to me. I am sorry that I didn't take care of Run2 data properly for jetvetomaptool!

Thank you for the review, and no worries, this happens all the time! We should have more careful review for PRs, and some unit tests to avoid this from happening...

IzaakWN commented 5 months ago

Made era check more permissive. Validated with:

from TauFW.PicoProducer.corrections.JetVetoMapTool import JetVetoMapTool
for era in ['2022_preEE','2022_postEE','2022E','2023_preBPIX','2023_postBPIX','2023C','2023D']:
  j = JetVetoMapTool(era)

Ready to merge!