search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 40 forks source link

Add Electron SF via correctionlib #77

Closed pmastrap closed 3 weeks ago

pmastrap commented 1 month ago

Old method is in ElectronSF_ROOT.py

IzaakWN commented 3 weeks ago

Did you validate the new tool for all eras in

  1. PicoProducer/test/testSFs.py
  2. In a realistic scenario with analysis modules? It would be good to check it runs for all eras with, for example, 
    pico.py run -m 10000 -c etau -y <ERA> -s DYJetsToLL*M-50

    because the correctionlib might run some errors for some eta/pt/... values...

pmastrap commented 3 weeks ago

Did you validate the new tool for all eras in

  1. PicoProducer/test/testSFs.py
  2. In a realistic scenario with analysis modules? It would be good to check it runs for all eras with, for example,
pico.py run -m 10000 -c etau -y <ERA> -s DYJetsToLL*M-50

because the correctionlib might run some errors for some eta/pt/... values...

yeah, I should change testSFs.py to work on all eras especially because of the phi dependance for 2023 . Regarding the second point, it should be already tested.

pmastrap commented 3 weeks ago

@IzaakWN fixed testSFs.py, now it works for all eras. Tested the analysis module with 2018UL, 2022, 2023. I think we can merge.

IzaakWN commented 3 weeks ago

Great, many thanks!