search

cms-tau-pog / TauFW

Analysis framework for tau analysis at CMS using NanoAOD
9 stars 40 forks source link

Adding Mu->Tau Fake Rate measurement stuff #9

Closed YWen-AI closed 1 year ago

YWen-AI commented 3 years ago

@IzaakWN @cardinia

IzaakWN commented 3 years ago

Hi, sorry I missed this!

The files are a bit in the wrong place, can you move them please?

The measurement-specific analysis modules should be in subdirectories to keep analysis/ clean:

mv PicoProducer/python/analysis/ModuleMuTau_MuTauFR.py PicoProducer/python/analysis/MuTauFakeRate/ModuleMuTau.py

Everything that has to do with fitting has to be in Fitter. I guess you need it to be available as an python imports, so please try

mkdir Fitter/python/models
mv PicoProducer/python/analysis/MuTauFakeRate/zttmodels.py Fitter/python/models/

Do you also have some python or shell script that runs text2workspace and combine for you? If not, can you write a short README.md with basic instructions for those command here, please?

PicoProducer/python/analysis/MuTauFR/README.md
IzaakWN commented 2 years ago

Hey @wywdiablo, can you also update this PR, please?

See previous comments, and please also add a reduced version of the JSON script https://github.com/cms-tau-pog/correctionlib/blob/TauPOG_v2/scripts/tau_createJSONs.py (https://github.com/cms-tau-pog/correctionlib/pull/8) in Fitter/MuTauFR/correctionlib/tau_createJSONs_VSmu.py. You can take as an example

The official JSON script should actually be maintained in the TauFW, rather than in correctionlib.

IzaakWN commented 2 years ago

Hi @wywdiablo, sorry for the long silence. I think the changes look fine. Since you have done a bunch of checks since, is there anything else in the meantime you like to add before merging?

YWen-AI commented 2 years ago

hi @IzaakWN , yes, I plan to add some documentation on how to run the measurement. But so far did not find a good time.

IzaakWN commented 1 year ago

Hi @wywdiablo, any updates?

IzaakWN commented 1 year ago

Hi @wywdiablo, any updates on the documentation so we can finally close the PR?

attikis commented 1 year ago

I suppose there won't be any documentation updates then. good to merge.