search

cmsb2g / B2GAnaFW

Analysis framework for Beyond Two Generations (B2G) Physics Analysis Group (PAG) of the Compact Muon Solenoid (CMS) Experiment
8 stars 33 forks source link

Added MiniIsolation for Electrons and Muons using the SUSY prescription #14

Closed jkarancs closed 9 years ago

jkarancs commented 9 years ago

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code: https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cc later if needed.

Best regards, Janos Karancsi

decosa commented 9 years ago

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi notifications@github.com<mailto:notifications@github.com> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code: https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cc later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14.

jkarancs commented 9 years ago

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa notifications@github.com wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi <notifications@github.com<mailto: notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cc later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

decosa commented 9 years ago

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi notifications@github.com<mailto:notifications@github.com> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi notifications@github.com<mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cchttp://Isolations.cc later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038.

jkarancs commented 9 years ago

Dear Annapaola,

The PR is done: https://github.com/cmsb2g/B2GAnaFW/pull/15/files

Unfortunately I couldn't test it because, the commit prior to this one shows an error for me (No module named runMETCorrectionsAndUncertainties) in CMSSW_7_4_8_patch1.

Best regards, Janos

On 10 August 2015 at 10:28, Annapaola de Cosa notifications@github.com wrote:

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi <notifications@github.com<mailto: notifications@github.com>> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa <notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi <notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cc< http://Isolations.cc> later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129362595.

decosa commented 9 years ago

Hi Janos,

Did you followed the recipe on the b2gFwk page?

https://twiki.cern.ch/twiki/bin/viewauth/CMS/B2GAnalysisFwk#CMSSW_7_4_X

It has been cross checked by others and works.

I think you missed :

git cms-merge-topic -u cms-met:METCorUnc74X

Moreover, in your last PR, did you applied your modifications on top of branch CMSSW_7_4_X_V6 ?

Thanks,

Annapaola

On 10 Aug 2015, at 12:26, János Karancsi notifications@github.com<mailto:notifications@github.com> wrote:

Dear Annapaola,

The PR is done: https://github.com/cmsb2g/B2GAnaFW/pull/15/files

Unfortunately I couldn't test it because, the commit prior to this one shows an error for me (No module named runMETCorrectionsAndUncertainties) in CMSSW_7_4_8_patch1.

Best regards, Janos

On 10 August 2015 at 10:28, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com> wrote:

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi notifications@github.com<mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.commailto:notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cchttp://Isolations.cc< http://Isolations.cc> later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129362595.

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129398577.

decosa commented 9 years ago

Sorry, I meant CMSSW_7_4_X_V5 in my previous email.

Annapaola

On 10 Aug 2015, at 14:04, Annapaola decosa@cern.ch<mailto:decosa@cern.ch> wrote:

Hi Janos,

Did you followed the recipe on the b2gFwk page?

https://twiki.cern.ch/twiki/bin/viewauth/CMS/B2GAnalysisFwk#CMSSW_7_4_X

It has been cross checked by others and works.

I think you missed :

git cms-merge-topic -u cms-met:METCorUnc74X

Moreover, in your last PR, did you applied your modifications on top of branch CMSSW_7_4_X_V6 ?

Thanks,

Annapaola

On 10 Aug 2015, at 12:26, János Karancsi notifications@github.com<mailto:notifications@github.com> wrote:

Dear Annapaola,

The PR is done: https://github.com/cmsb2g/B2GAnaFW/pull/15/files

Unfortunately I couldn't test it because, the commit prior to this one shows an error for me (No module named runMETCorrectionsAndUncertainties) in CMSSW_7_4_8_patch1.

Best regards, Janos

On 10 August 2015 at 10:28, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com> wrote:

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi notifications@github.com<mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.commailto:notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://isolations.cc/http://Isolations.cchttp://isolations.cc/< http://Isolations.cchttp://isolations.cc/> later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129362595.

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129398577.

oiorio commented 9 years ago

Hi Janos,

Just to comment:

I cross-checked and for me the recipe works out of the box as written in there:

https://github.com/cmsb2g/B2GAnaFW/blob/CMSSW_7_4_X_V5/README.md

Cheers, Orso

From: Annapaola de Cosa [notifications@github.com] Sent: 10 August 2015 14:04 To: cmsb2g/B2GAnaFW Subject: Re: [B2GAnaFW] Added MiniIsolation for Electrons and Muons using the SUSY prescription (#14)

Hi Janos,

Did you followed the recipe on the b2gFwk page?

https://twiki.cern.ch/twiki/bin/viewauth/CMS/B2GAnalysisFwk#CMSSW_7_4_X

It has been cross checked by others and works.

I think you missed :

git cms-merge-topic -u cms-met:METCorUnc74X

Moreover, in your last PR, did you applied your modifications on top of branch CMSSW_7_4_X_V6 ?

Thanks,

Annapaola

On 10 Aug 2015, at 12:26, János Karancsi notifications@github.com<mailto:notifications@github.com> wrote:

Dear Annapaola,

The PR is done: https://github.com/cmsb2g/B2GAnaFW/pull/15/files

Unfortunately I couldn't test it because, the commit prior to this one shows an error for me (No module named runMETCorrectionsAndUncertainties) in CMSSW_7_4_8_patch1.

Best regards, Janos

On 10 August 2015 at 10:28, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com> wrote:

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi notifications@github.com<mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.commailto:notifications@github.com>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cchttp://Isolations.cc< http://Isolations.cc> later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129362595.

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129398577.

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129423309.

jkarancs commented 9 years ago

Dear Annapaola,

Yes, that line I was missing. Yes, I did my changes in the development CMSSW_7_4_X_V5 branch (I think you meant V5 not V6, right?).

Now, I tested my commit and it works perfectly. I have to make a new branch on top of your latest commit an hour ago, since I branched off from the previous commit and the same file was modified by you. Please check my new commit and if you agree, please accept it before doing any further modifications. You can see the diff here: https://github.com/cmsb2g/B2GAnaFW/pull/16/files

Best regards, Janos

On 10 August 2015 at 14:04, Annapaola de Cosa notifications@github.com wrote:

Hi Janos,

Did you followed the recipe on the b2gFwk page?

https://twiki.cern.ch/twiki/bin/viewauth/CMS/B2GAnalysisFwk#CMSSW_7_4_X

It has been cross checked by others and works.

I think you missed :

git cms-merge-topic -u cms-met:METCorUnc74X

Moreover, in your last PR, did you applied your modifications on top of branch CMSSW_7_4_X_V6 ?

Thanks,

Annapaola

On 10 Aug 2015, at 12:26, János Karancsi <notifications@github.com<mailto: notifications@github.com>> wrote:

Dear Annapaola,

The PR is done: https://github.com/cmsb2g/B2GAnaFW/pull/15/files

Unfortunately I couldn't test it because, the commit prior to this one shows an error for me (No module named runMETCorrectionsAndUncertainties) in CMSSW_7_4_8_patch1.

Best regards, Janos

On 10 August 2015 at 10:28, Annapaola de Cosa <notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

Yes, please, send it to the new branch.

Thanks,

Annapaola

On 09 Aug 2015, at 19:18, János Karancsi <notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com>> wrote:

Dear Annapaola,

That sounds good. I originally sent the PR to master. Let me know if you would like me to send another PR in the new branch.

Best regards, Janos

On 8 August 2015 at 18:57, Annapaola de Cosa <notifications@github.com mailto:notifications@github.com mailto:notifications@github.com> wrote:

Hi Janos,

I am preparing a new branch for fixing the MET issue. I would prefer to have the MiniIsolation for leptons in this new branch once it is stable. This will be the one used for the next production.

Cheers,

Annapaola

On 08 Aug 2015, at 11:45, János Karancsi <notifications@github.com mailto:notifications@github.com mailto:notifications@github.com<mailto: notifications@github.commailto:notifications@github.com<mailto: notifications@github.com>>> wrote:

Dear B2G,

In this commit I added the computation of the MiniIsolation for Electrons/Muons using the SUSY prescription posted here: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html code:

https://github.com/manuelfs/CfANtupler/blob/master/minicfa/interface/miniAdHocNTupler.h#L54-L120

I hope this will be a useful addition. As a sidenote: The B2G 2D cut computation can be added to Isolations.cchttp://Isolations.cc< http://Isolations.cc>< http://Isolations.cc> later if needed.

Best regards, Janos Karancsi

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/14

Commit Summary

  • Added MiniIsolation for Electrons and Muons using the SUSY prescription

File Changes

https://github.com/cmsb2g/B2GAnaFW/pull/14/files#diff-4> (9)

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129012656.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129218038>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129362595.

— Reply to this email directly or view it on GitHub< https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129398577>.

— Reply to this email directly or view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/14#issuecomment-129423309.

jkarancs commented 9 years ago

Sorry for these many PRs, I'm still learning how to use git the best way. I'm closing this thread, please check the new PR: https://github.com/cmsb2g/B2GAnaFW/pull/16

I hope I did everything correctly. :)