cmsb2g / B2GAnaFW

Analysis framework for Beyond Two Generations (B2G) Physics Analysis Group (PAG) of the Compact Muon Solenoid (CMS) Experiment
8 stars 33 forks source link

Fixed syntax errors in b2gedmntuples_cfg.py. #17

Closed TC01 closed 9 years ago

TC01 commented 9 years ago

I tried to use Janos's B2GTTrees code to ntuplize some Monte Carlo today and discovered some syntax errors in test/b2gedmntuples_cfg.py. There was some inconsistent indentation which I made consistent enough such that the code ran, and also I had to replace some "=" with "==" in a couple of if statements.

dmajumder commented 9 years ago

This should also be propagated to the branches CMSSW_7_4_X_V6_50ns and CMSSW_7_4_X_V6_25ns

TC01 commented 9 years ago

Do you want me to open additional pull requests to those branches?

decosa commented 9 years ago

Hi Ben,

Yes, please, go ahead.

Thank you.

Annapaola

On 23 Sep 2015, at 01:25, Ben Rosser notifications@github.com<mailto:notifications@github.com> wrote:

Do you want me to open additional pull requests to those branches?

— Reply to this email directly or view it on GitHubhttps://github.com/cmsb2g/B2GAnaFW/pull/17#issuecomment-142451749.

TC01 commented 9 years ago

So taking a look, I'm not sure this is actually necessary. It seems that 84cb723f7b703138e6f00d100f9d0bd4974bcedc, the commit that introduced the error, was never pushed to either of these branches to begin with. Observe here that the old global tag code is still there.

dmajumder commented 9 years ago

There were some mail exchanges on getting 84cb723 into these two branchs. Once other developments are done this will be synchronised.