search

cmsb2g / B2GAnaFW

Analysis framework for Beyond Two Generations (B2G) Physics Analysis Group (PAG) of the Compact Muon Solenoid (CMS) Experiment
8 stars 33 forks source link

Electron ID fixes #58

Closed jkarancs closed 7 years ago

jkarancs commented 7 years ago

Content of this PR:

[1] https://hypernews.cern.ch/HyperNews/CMS/get/egamma/1795.html

skyriacoCMS commented 7 years ago

Hey Janos,

Thanks a lot for checking this in an independent way and finding - my typos

Cheers,

Savvas Kyriacou Department of Physics and Astronomy Rutgers, The State University of New Jersey

CERN B8 R-020 ,__, (o.o) /),,,,) " "

On Sun, Oct 2, 2016 at 7:09 PM, János Karancsi notifications@github.com wrote:

Content of this PR:

  • Fix HEEP id name in config and add missing token inititalization
  • Add new variable dEtaInSeed, which uses correctly the corresponding userfloat, also keep the original variable in case needed later
  • Spotted a typo in the EGamma VID config for Loose ID, see [1]. Until it is fixed, a temporary recipe is provided (one have to simply rewrite the number in the corresponding python file after checkout).

[1] https://hypernews.cern.ch/HyperNews/CMS/get/egamma/1795.html

You can view, comment on, or merge this pull request online at:

https://github.com/cmsb2g/B2GAnaFW/pull/58 Commit Summary

  • Fix HEEP ID, Add/Fix dEtaInSeed variable, Temp. fix recipe for loose cut based ID

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/58, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCcD4Mx2GSxz0MK_5_Gu0loCa4-93Tzks5qv-VhgaJpZM4KMDvT .

dmajumder commented 7 years ago

@jkarancs I have merged your PR There is no reply to your HN post https://hypernews.cern.ch/HyperNews/CMS/get/egamma/1795.html So do we assume that the dEtaInSeed cut on the TWiki is correct, and that in the code is wrong?

skyriacoCMS commented 7 years ago

Hello All,

Regarding the cut value for dEtaSeedIn and which is correct. What the Twiki has - which agrees with the cut presented here [1] match. Thus I expect this is the correct one. Also given the scale of the other cut values for the the other working points: veto loose medium tight 0.00749 0.00477 0.00311 0.0030 I really think this is the correct value., plus you see that the cut vaIues for this variable tighten up as we move to tighter WPs - as for the rest variables too.

I will expect ofcourse Ilya's response but I think the code has a typo and not the twiki / presentation.

[1] https://indico.cern.ch/event/482677/contributions/2259342/attachments/1316731/1972911/talk_electron_ID_spring16_update.pdf

Cheers,

Savvas Kyriacou Department of Physics and Astronomy Rutgers, The State University of New Jersey

CERN B8 R-020 ,__, (o.o) /),,,,) " "

On Mon, Oct 3, 2016 at 4:01 PM, dmajumder notifications@github.com wrote:

Merged #58 https://github.com/cmsb2g/B2GAnaFW/pull/58.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cmsb2g/B2GAnaFW/pull/58#event-810309781, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCcDxSk5oViUSiB8Dmgd3s1MgNqejYZks5qwQqugaJpZM4KMDvT .