search

cmsb2g / B2GAnaFW

Analysis framework for Beyond Two Generations (B2G) Physics Analysis Group (PAG) of the Compact Muon Solenoid (CMS) Experiment
8 stars 33 forks source link

Cmssw 8 0 x v3 #74

Closed skyriacoCMS closed 7 years ago

skyriacoCMS commented 7 years ago

Hello all,

I have made some small changes to the PhotonJets.cc . No new variables or anything.

After this I think I m ready from my side for a new tag.

Cheers,

jkarancs commented 7 years ago

Dear Savvas,

This last PR which was merged, did not compile, see the error below this message. Could you please also add the MVA ID for electrons? The General Purpose one is computed already (as userFloat), but not added as a variable. Just in case could you also add the HZZ one? It would be very useful for electrons between pt [5,10], for which the GP one does not work.

Bests, Janos

/data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc: In member function 'virtual void PhotonJets::produce(edm::Event&, const edm::EventSetup&)': /data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc:253:17: error: conflicting declaration 'fastjet::PseudoJet jetnew' PseudoJet jetnew = pruner(jet_new[0]);
^ /data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc:250:40: note: previous declaration as 'std::vector jetnew' std::vector jetnew = sorted_by_pt(clust_seq_08.exclusive_jets_up_to(1)); ^ /data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc:253:33: error: 'jet_new' was not declared in this scope
PseudoJet jetnew = pruner(jet_new[0]);
^ /data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc:269:17: error: 'class std::vector' has no member named 'has_pieces' if(jetnew.has_pieces()){
^ /data/jkarancs/CMSSW/SusyAnalysis/Ntuples/CMSSW_8_0_26_patch2/src/Analysis/B2GAnaFW/src/PhotonJets.cc:277:9: error: 'class std::vector' has no member named 'has_parents' jetnew.has_parents(sub0,sub1);

jkarancs commented 7 years ago

Dear @skyriacoCMS

I shortly send a PR in which I add the HZZ version of the ID and also the categories which also might be useful. I didn't know how to fix the photonjets file so I did not attempt that.