Add ele MVA IDs, fix uncorrSDMass

cmsb2g / B2GAnaFW

Analysis framework for Beyond Two Generations (B2G) Physics Analysis Group (PAG) of the Compact Muon Solenoid (CMS) Experiment

8 stars 33 forks source link

Add ele MVA IDs, fix uncorrSDMass #76

Closed jkarancs closed 7 years ago

jkarancs commented 7 years ago

Contents of this PR:

Add general purpose (tight) and HZZ (very loose) electron MVA values/categories
Fix an issue with uncorrected AK8 Puppi SoftDrop mass used for W tagging [1]
- Match by closest distance with the MINIAOD AK8 collection, use subjets("SoftDropPuppi")
- Use correctedP4(0) of subjets, to exactly match recipe [2]
Add corrected Puppi SD mass, recommended for top tagging [3]
- Computed from the same "SoftDropPuppi" subjets, but with L1L2L3 corrections applied
Modify TriggerResults process to "PAT" in order to access latest filters in ReMiniAOD [4]
Fix JEC era name for MC, Update Run2016H GT

[1] - https://twiki.cern.ch/twiki/bin/view/CMS/JetWtagging?rev=54#Working_points_and_scale_factors [2] - https://github.com/cms-jet/PuppiSoftdropMassCorr/#get-uncorrected-puppi-soft-drop-mass-from-miniaod [3] - https://twiki.cern.ch/twiki/bin/view/CMS/JetTopTagging?rev=14#13_TeV_working_points_CMSSW_8_0 [4] - https://twiki.cern.ch/twiki/bin/view/CMSPublic/ReMiniAOD03Feb2017Notes#Event_flags

jkarancs commented 7 years ago

@dmajumder Can you please review this PR? If you agree with it's contents please merge, otherwise let me know if I need to change something. Thank you in advance!

dmajumder commented 7 years ago

@jkarancs sorry for the delay. will have a look by tomorrow

dmajumder commented 7 years ago

@jkarancs sorry for further delay. I think, based on the above, I'd suggest switching back to the previous collections for the subjets/ jets. The next tag will be almost only for processing the 03Feb data and we'd prefer compatibility with the previous tags.

jkarancs commented 7 years ago

@dmajumder I switched the jet collections back in my latest commit

skyriacoCMS commented 7 years ago

@dmajumder @jkarancs Hello guys, again, once Janos changes are integrated I'll fix the compilation error PhotonJets creates.

Cheers,

dmajumder commented 7 years ago

@skyriacoCMS merged this PR, Please go ahead with your changes

skyriacoCMS commented 7 years ago

@jkarancs @dmajumder Doing it now!

Cheers

skyriacoCMS commented 7 years ago

@dmajumder @jkarancs

Hey guys, I made my changes and compiled - all good. I made a pull request. When I run I get the following error regarding the subjets:

-- Begin Fatal Exception 27-Apr-2017 14:11:55 CDT----------------------- An exception of category 'SubjetsNotFound' occurred while [0] Processing run: 275847 lumi: 957 event: 1234045064 [1] Running path 'endPath' [2] Calling event method for module PoolOutputModule/'edmNtuplesOut' [3] Calling produce method for unscheduled module CandViewNtpProducer/'jetsAK8CHS' [4] Calling produce method for unscheduled module BoostedJetToolboxUserData/'boostedJetUserDataAK8' Exception Message: Label SoftDropPuppi does not match any subjet collection ----- End Fatal Exception ------------------------------------------------- 27-Apr-2017 14:11:55 CDT Closed file root://cmsxrootd-site.fnal.gov//store/data/Run2016C/JetHT/MINIAOD/03Feb2017-v1/110000/86F82CD1-C7EB-E611-ACD3-008CFA110B08.root

Cheers,

jkarancs commented 7 years ago

@skyriacoCMS You are right, I forgot to also switch back the subjet label. In your PR, could you please changes this line from "SoftDropPuppi" to "SoftDrop"? That will fix it, thank you in advance!

https://github.com/jkarancs/B2GAnaFW/blob/d29a3fb8f4d1c647b85bbb67f7e7cfb8b262d2c4/src/BoostedJetToolboxUserData.cc#L94