search

cmsdaq / DAQAggregator

Aggregate monitoring data from the CMS DAQ system
0 stars 3 forks source link

logging the exception if a .smile file can not be deserialized #88

Closed andreh12 closed 7 years ago

andreh12 commented 7 years ago

added the exception to the call to the logger in class StructureSerializer. This helps to understand why a file can not be deserialized (e.g. unexpected values for a field).

gladky commented 7 years ago

Just below there is i.printStackTrace(); - Is it not sufficient?

andreh12 commented 7 years ago

good point about the printStackTrace() -- I actually only noticed after submitting the pull request.

The output of printStackTrace() does not appear in my IDE when running the test, the output of the logger does on the other hand. So I would propose even to go one step further and remove i.printStackTrace() in favour of adding the exception to the call of the logger function.

andreh12 commented 7 years ago

in order to avoid double printing I now removed the call to printStackTrace(). For consistency I also applied this change to the method deserializeFlashlist() in the same class.