Feedback

[github-classroom[bot]]

:wave:! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens. Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @bdalfavero @xiaothua @ziyucheng7 @Ledengary @AmingSong

[vamads]

Teaching team feedback:

• 1 Part 1 Q 2: 2N^3 25/26

Peer Feedback: Warm up: All answers are correct FLOPS for first qns is not right They allegedly got the operation count for the first question wrong, but I still think there are 3 operations there... It's correct. Error in kernel 4, but flops and mem traffic correct 
Part 1: The plot is very explanatory, although the discussion on how the vector processing unit influences performance was not included.
did not have 2N^3 but everything looks good! The code was way more readable than ours, and the report cleanly articulates the correct findings.

1. 3/3
2. 1/1 weird format :(
3. 2/2
4. 0.5/1 no consideration for multiple mult/add units or vector processing units affecting speed
5. 2/2
6. 1/1 Part 2: Information for all the points above is conveyed accurately by the tables. The discussion on how the slants reflecting the different memory hierarchies could be expanded. looks good to me Everything looks very clean and correct (as far as I can tell). Every plot and reasoning is thorough and complete (and correct, I think). q3: 3/3 // no analysis peak in writing, but it's on graph. q4: 3/3 rooflines 4/4 connecting memory hierarchy slants in roofline model to features in matrix matrix multiplication: 2/2