Atomic BOOL seem to return 0x01 rather than 0xff. - Githubissues

cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.

MIT License

265 stars 106 forks source link

Atomic BOOL seem to return 0x01 rather than 0xff. #30

Closed pfumagalli closed 6 years ago

pfumagalli commented 6 years ago

Description, Motivation, and Context

This simply changes the way BOOL are checked when parsed atomically

How Has This Been Tested?

Yes, locally on a Logix5572 (Firmware 31.011)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

See issue #29

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 92

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 51.024%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/tag/index.js	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 85:	0.08%
Covered Lines:	472
Relevant Lines:	882

💛 - Coveralls

jhenson29 commented 6 years ago

@cmseaton42 I tested this on v20 and v31. Should be okay. You can see my other comment on how we got here in issue #29.

Version increment to 1.2.1?

cmseaton42 commented 6 years ago

@pfumagalli Thanks for the catch!