bugfix - Githubissues

cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.

MIT License

265 stars 106 forks source link

bugfix #37

Closed jhenson29 closed 6 years ago

jhenson29 commented 6 years ago

Tag.unstageWriteRequest had an incorrect reference to Tag.state.tag.controllerValue

Description, Motivation, and Context

Incorrect referenced caused tag.value to be undefined in some cases. (If the same value was written to the PLC two times in a row).

How Has This Been Tested?

Tested with writes to PLC.

Screenshots (if appropriate):

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

Fixes #36

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 108

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 50.982%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/tag/index.js	0	3	0.0%
<!--	Total:	0	3	0.0%	-->

Totals
Change from base Build 107:	-0.04%
Covered Lines:	472
Relevant Lines:	883

💛 - Coveralls

cmseaton42 commented 6 years ago

Awesome, thanks for the fix! I'll pull this when I'm back in front of my computer today :)