Fix for hanging timeout

cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.

MIT License

263 stars 105 forks source link

Fix for hanging timeout #66

Open jgentes opened 4 years ago

jgentes commented 4 years ago

When using methods from this library, there's a ~10 second delay before the process exits. It's due to the setTimeout in the promiseTimeout utility, which never gets cleared if the promise resolves successfully. Adding a clearTimeout here takes care of that.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 147

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 51.102%

Totals
Change from base Build 141:	0.08%
Covered Lines:	474
Relevant Lines:	885

cmseaton42 / node-ethernet-ip

Fix for hanging timeout #66

Pull Request Test Coverage Report for Build 147

💛 - Coveralls