[WIP] Add configuration option to unconnected send timeout - Githubissues

cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.

MIT License

263 stars 105 forks source link

[WIP] Add configuration option to unconnected send timeout #68

Open gfcittolin opened 4 years ago

gfcittolin commented 4 years ago

Description, Motivation, and Context

Implements changes as discussed in #67 to allow custom-setting the value of timeout on unconnected send messages

How Has This Been Tested?

Tested with SoftLogix

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 148

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 51.102%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/controller/index.js	1	2	50.0%
<!--	Total:	1	2	50.0%	-->

Totals
Change from base Build 141:	0.08%
Covered Lines:	473
Relevant Lines:	884

💛 - Coveralls