search

cmsimple-xh / xhshop

A simple shop for CMSimple_XH
GNU General Public License v3.0
4 stars 3 forks source link

Adopt Phan #233

Closed cmb69 closed 1 year ago

cmb69 commented 3 years ago

A static analyzer helps to detect some potential issues without even running the code. Phan appears to be particularly suitable for seriously legacy code. For now we configure it to report critical issues only.

~~To avoid the dependency hell, we don't add it as composer development requirement, but rather introduce Phive.~~

We also run the Phing target phan for CI.

Note that this raises the requirement to CMSimple_XH ≥ 1.7.0, since earlier versions didn't use namespaced classes (and working around that doesn't seem sensible).

cmb69 commented 3 years ago

Ah, look at the failing CI. ;)

cmb69 commented 1 year ago

Rebased, and removed the Phive requirement (at least for now there don't appear issues with composer, and this way we keep it simpler).

If we don't want to raise the requirements to CMSimple_XH ≥ 1.7.0 right now, I'm fine with that. I'll nonetheless play around with Phan a bit; it might catch some potential issues.