cmsis-svd / cmsis-svd-data

Aggregration of ARM Cortex-M (and other) CMSIS SVDs
Apache License 2.0
34 stars 16 forks source link

LPC11xx_v6.svd has multiple enumerated values with the same name #17

Open odinthenerd opened 8 years ago

odinthenerd commented 8 years ago

So far we have been correcting names of things in extention files in order to not mess with the SVD (in order to stay open to drop in improvements from the vender), however since the extention files index things by name ambiguities are impossible to correct.

The offending tag is <name>COUNTER_MODE_TC_IS_</name> which occurs three times in the CTM field of the CTCR register all with different values.

What should we do to fix this?

kblomqvist commented 8 years ago

Just an idea... maybe you could append the value into the name. Either in a separate post-process step or in all cases where the last character of the name equals to "_".

COUNTER_MODE_TC_IS_1 COUNTER_MODE_TC_IS_2 COUNTER_MODE_TC_IS_3

odinthenerd commented 8 years ago

good idea, maybe we could also make an alternative indexing mode in the extension files too. I'm a little reluctant to make too many changes because of this because in my mind it is simply an NXP error. I'm also considering just changing the svd file in this case.

Samonitari commented 7 years ago

Hi all! I know this is an old issue/thread, but seemingly nobody is tending to it. Most NXP LPC SVD's are obviously autogenerated from the docs, with truncating, so this issue is present in them. Either the header generator won't eat them, or their output is unchecked, and won't work. I made corrections in LPC82X.svd - which is not in this repo by the way - and will definitely do the same for some others.

So if no objections, I would like to hijack this issue, and document here the progression.

odinthenerd commented 7 years ago

go for it, glad to here someone is working on it!