cmsis-svd / cmsis-svd-data

Aggregration of ARM Cortex-M (and other) CMSIS SVDs
Apache License 2.0
38 stars 17 forks source link

Add NXP MK64F12 #2

Closed florianhofhammer closed 11 months ago

florianhofhammer commented 1 year ago

Hi,

I've been working with some dev boards based on your nice collection of SVDs recently. One board I was looking at, NXP's Freedom K64F, does not yet have the SVD in the repository for the underlying MCU. I've downloaded the SDK from NXP's site (https://mcuxpresso.nxp.com/download/79732013c16f95617a5b2db02d42f78b, requires NXP account) and extracted the corresponding SVD.

This should probably only be merged after #1 has gone through, as I based my PR on the branch #1 tries to merge into main. The relevant change is in eb72d1c, the other commits stem from #1.

Cheers, Florian

VincentDary commented 1 year ago

Thank you very much for your contribution, I will review it as soon as possible.

florianhofhammer commented 1 year ago

I'd like to mention that there's already the SVD for the Freescale MK64F12 which this chip should be based on after NXP acquired Freescale, but the SVDs differ quite significantly. While for some parts of the SVD this might just be reordering of peripherals or rephrasing of descriptions, for other differences there are clear changes (e.g., registers switching from read-write to read-only, offsets changing,...). I'm not sure whether NXP actually changed something about the chip after the acquisition of Freescale but I think the SVDs are different enough that it might make sense having both in the repository. Let me know what you think!

VincentDary commented 11 months ago

@florianhofhammer, it's ok, I have check the svd file signature of your contribution with the svd file contains in the SDK (link above).

$ unzip -qq SDK_2_11_0_FRDM-K64F.zip -d SDK_2_11_0_FRDM-K64F
$ wget https://raw.githubusercontent.com/florianhofhammer/cmsis-svd-data/eb72d1c94e42611937d98f81558a887167268cec/data/NXP/MK64F12.svd
$ sha512sum MK64F12.svd SDK_2_11_0_FRDM-K64F/devices/MK64F12/MK64F12.xml
4227296db9a8beca3239a7a180092e1ef61969c8145c87e57e7160e6744cf8b1571fce8b2ae8b4cb4efd45c308b98a4b04445ee276481fb9545904dc04b99d3d  MK64F12.svd
4227296db9a8beca3239a7a180092e1ef61969c8145c87e57e7160e6744cf8b1571fce8b2ae8b4cb4efd45c308b98a4b04445ee276481fb9545904dc04b99d3d  SDK_2_11_0_FRDM-K64F/devices/MK64F12/MK64F12.xml