cmsis-svd / cmsis-svd-data

Aggregration of ARM Cortex-M (and other) CMSIS SVDs
Apache License 2.0
38 stars 17 forks source link

Update STM32H7A3x #6

Closed ii8 closed 1 month ago

VincentDary commented 1 month ago

@ii8, thank you very much for your contribution, but I can't find the original file from vendor for the update, I have tried with the file STM32H7A3.svd provided in the ST archive stm32h7-svd.zip, but the signatures mismatch.

$  wget \
  --user-agent='Mozilla/5.0 (X11; Linux i686; rv:131.0) Gecko/20100101 Firefox/131.0' \
  https://www.st.com/resource/en/svd/stm32h7-svd.zip
$ unzip stm32h7-svd.zip
$ cd STM32H7_svd/STM32H7_svd_V1.9
$ sha512sum STM32H7A3.svd > ../../hash_from_st.txt
$ cd ../..
$ sed -i -e 's/STM32H7A3.svd/STM32H7A3x.svd/g' hash_from_st.txt
$ git clone https://github.com/BenBE/cmsis-svd-data.git
$ cd cmsis-svd-data
$ git checkout ii8-main
$ cd data/STMicro
$ sha512sum -c ../../../hash_from_st.txt
STM32H7A3x.svd: FAILED
sha512sum: WARNING: 1 computed checksum did NOT match
$ echo $?
1

Please, can you provide the original source URL of your file ? (from vendor)

hash_from_st.txt

ii8 commented 1 month ago

I updated this file to match the datasheet from the vendor. I didn't look at any svd file provided by ST, only their datasheet. At the time (to my knowledge) there was no up-to-date and correct vendor provided svd available, it was a while ago so the situation could have changed since then.

VincentDary commented 3 weeks ago

@ii8

I updated this file to match the datasheet from the vendor. I didn't look at any svd file provided by ST, only their datasheet. At the time (to my knowledge) there was no up-to-date and correct vendor provided svd available, it was a while ago so the situation could have changed since then.

Thank you very much for your feedback, but this is not the right place for your contribution. Unfortunately, due to the license on the SVD files, we don't directly change SVD files as part of this project. We might be able to convince the vendor (in this case ST) to make the change.

IMO, the file STM32H7A3x.svd is now the file STM32H7A3.svd, it is officialy maintained by the Open-CMSIS-Pack Github organisation in the STM32H7xx_DFP repository. You can submit a patch for the STM32H7A3.svd file and when it will be merged propose a patch in this repository.

I left this issue open for future update from vendor.