rain sounds play in space

[stanalbatross]

Testmerges

irrelevant

Description of the bug

rain plays in space areas outside the almayer

What's the difference with what should have happened?

obvious, it should not

How do we reproduce this bug?

wait for a rain event or trigger one then go into space outside almayer

Issue Bingo

• [ ] Issue could be reproduced at least once
• [X] Issue happened in a recent (less than 7 days ago) round
• [X] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Huffie56]

i tested it and we still got weather noise in space. trying to investigate it but it's weird only the sound seem to be playing not the rain... as far as i remember it was there since geeves added weather...

[Huffie56]

it seem to ignore the fact that weather_enabled = FALSE for the space area. seem to me that it mean that sound trig erring is separated from the animation of rain being on. after a few test and exploring of the code i think it's a problem that seem specific to only space area where for some reason they get the weather ambiance sound when they shouldn't

[Huffie56]

could be this part of the code responsible

[Huffie56]

this PR will remove the weather sound in space. https://github.com/cmss13-devs/cmss13/pull/3145

[Huffie56]

@ItsVyzo my PR got merge it fix this issue. https://github.com/cmss13-devs/cmss13/pull/3145

[ItsVyzo]

@Huffie56 closed! Thank you!