cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
82 stars 468 forks source link

VP78 Pistol Attachment Bug #3485

Open Wintermote opened 1 year ago

Wintermote commented 1 year ago

Testmerges

3088, #3298, #3424, #3470, #3481, #3473

Description of the bug

The stats of the VP78 do not appear to change at all whether their attachments are activated or not.

The attachments are built in and cannot be removed, so I'm not sure if their stat changes are always activated or if they're meant to be activated when the flashlight and laser are turned off but aren't.

What's the difference with what should have happened?

Activating the flashlight and laser on the VP78 should change the stats of the weapon, but that doesn't appear to be the case

How do we reproduce this bug?

  1. Find VP78
  2. Check its stats
  3. Activate the flashlight and laser
  4. Check the stats again
  5. There will not be any changes

Issue Bingo

morrowwolf commented 1 year ago

Looks like they're always on but yes the stats gain should be removed if turned off. Good catch!