search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
101 stars 563 forks source link

Fire patting is blocked by tile wide objects (Stairs // Weeds // Etc) #4214

Open gitbirb opened 1 year ago

gitbirb commented 1 year ago

Testmerges

4003: 'Brings automatic weaponry to the marine and surv arsenal' by Zonespace27 at commit db622ab58d #4182: 'Project ARES: Admin Console' by realforest2001 at commit cb4d9713bb #4131: 'Telephones Networking' by realforest2001 at commit 992e759b1a #3865: 'New UPP guns' by CapCamIII at commit 2b2ba4a34e #4035: 'Faction Access & Almayer Security Overhaul' by realforest2001 at commit 59b87453d9 #4111: 'Project ARES: Functional Access Tickets' by realforest2001 at commit da5106e9a2

Description of the bug

If you're a Xeno, and try patting a fire on a tile, it clicks tile-sized objects instead of the floor tile and thus means you have to alt click and hit the floor in order to pat.

weird tile-sized objects may include: The tile-sized pipes on a lot of maps Stairs Couches Weeds etc.

What's the difference with what should have happened?

You should be able to pat fire as Xeno even if there is tile-sized objects on the tile. It's INCREDIBLY annoying on staircases, for example, since if flamed, Xenos just can't pat it without alt clicking.

How do we reproduce this bug?

  1. Flame a staircase tile
  2. Be a xeno
  3. Help intent click the flaming stair (You stare at the stair cluelessly)
  4. Fire stays
  5. Alt click then press the floor tile
  6. Fire gone ...

Issue Bingo

Huffie56 commented 1 year ago

@gitbirb is this happening almayer stairs only? i guess the rest certainly a layer issue.... the flame appear behind objects?

gitbirb commented 1 year ago

@gitbirb is this happening almayer stairs only? i guess the rest certainly a layer issue.... the flame appear behind objects?

AFAIK, happens with all stairs(?) (i'm not sure if the almayer stairs are part of the floor? If they are it might not have this issue).

The problem isn't that the flame appears behind objects: It's that if you try to pat out the flames, you click the stair, but you need to click the floor in order to pat. Clicking the floor is blocked by the stair.

Huffie56 commented 1 year ago

at out the flames, you click the stair, bu

i see way less easy to solve than i was thinking.... thanks for the precision.