search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
94 stars 510 forks source link

[Multiple] Alt + Click Shows Multiple Icons #4396

Open TeDGamer opened 1 year ago

TeDGamer commented 1 year ago

Testmerges

4379, #4182, #4378

Description of the bug

image

Similar to https://github.com/cmss13-devs/cmss13/issues/4369

But this one when checking the computers seems to be fixed

What's the difference with what should have happened?

Show only the icons for the items

How do we reproduce this bug?

  1. Alt-click varadero's ship ( where the glowing slime is)

Issue Bingo

Huffie56 commented 1 year ago

i can confirmed i had the same

TeDGamer commented 1 year ago

image

TeDGamer commented 1 year ago

image

TeDGamer commented 1 year ago

image

Huffie56 commented 9 months ago

that's old not sure where it is now... reproduction it need

Huffie56 commented 8 months ago

https://discord.com/channels/150315577943130112/964684928161808384/1191453491282051072 last report of it.

SabreML commented 8 months ago

I can't remember the exact details since it's been about 2 years since I last worked on it, but as far as I remember this is caused by a combination of the atom's icon_state being null (or being something that isn't in the .dmi file), and the .dmi file not having a default state set.

For example the two 'remains' ones above were likely caused by the xeno being gibbed: https://github.com/cmss13-devs/cmss13/blob/b1e7b7029a48267d1e46f360d37ecd7ad1d5425a/code/modules/mob/living/carbon/xenomorph/death.dm#L137-L140 https://github.com/cmss13-devs/cmss13/blob/b1e7b7029a48267d1e46f360d37ecd7ad1d5425a/code/game/objects/effects/decals/remains.dm#L10-L15

death.dm L139 sets the remains effect's icon to the same as the dead xeno's, but since its icon_state of "remainsxeno" isn't a state in the xeno dmi, and there isn't a fallback 'default' state in there either, it just displays the whole file.