RO > QM Hours/Medal progression

eMiiXi commented 1 year ago

Testmerges

Irrelevant.

Description of the bug

Since the name change from RO to QM, i now have 3 QM roles in my playtimes. Two from normal gamemode and one being QM from Whiskey Outpost. My RO playtime been sucesfully renamed as Quartermaster for the regular gamemode, and the hours still there (266+), yet it doesn't recognise the playtimes for the medal progression anymore. I spawn with no medal, I think its either having a conflict or counting the wrong QM hours, and only couting a new Quartermaster role that appear on my playtime list, instead of the regular one. Since i played few more hours as QM, I now have a secondary QM role with 20+ hours, and now i spawn with a bronze medal, when i have another QM role with the same name, but 266hours.

What's the difference with what should have happened?

Spawn with the correct medal and count the playtime on the renamed role, instead of a now secondary QM role with the same name.

How do we reproduce this bug?

Have played RO before
Made the transiction of name
Its now counting QM hours on a secondary QM role, instead of the renamed one. ...

Issue Bingo

[X] Issue could be reproduced at least once
[X] Issue happened in a recent (less than 7 days ago) round
[X] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

fira commented 1 year ago

This probably requires DB migration of the playtime entries. This gets overlooked pretty much every time a role is renamed. Unfortunately i'm not sure how to do this in a non destructive way merging both...

Huffie56 commented 6 months ago

maybe this could be fixed with a PR that merge every playtime into one during a blank round.?

cmss13-devs / cmss13