cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
96 stars 545 forks source link

getting spaced as queen removes you from the "who was queen" section #4435

Open private-tristan opened 1 year ago

private-tristan commented 1 year ago

Testmerges

4379: 'Science Annex Yard Readdition' by c4xmaniac2 at commit a30f108e38 #4378: 'LV Intel Update' by c4xmaniac2 at commit 67b2ec461b #4063: 'Yautja Change Holder' by realforest2001 at commit fcc6c86cd3 #4391: 'Hijack objectives' by morrowwolf at commit 263df75edf #4422: 'Remove Note Fix' by realforest2001 at commit 2d8f75233c #4182: 'Project ARES: Admin Console' by realforest2001 at commit 3456b54b43 #4423: 'Fixes the tradeband scanner.' by realforest2001 at commit 7e7cc5d637

Description of the bug

get spaced by lifeboats as queen round ends don't see your tag

What's the difference with what should have happened?

get spaced by lifeboats as queen round ends see your tag.

How do we reproduce this bug?

1.spawn a queen

  1. space it
  2. end the round ... im not listed in the who was queen. image

Issue Bingo

morrowwolf commented 1 year ago

DELETED FROM EXISTENCE

koltoast commented 1 year ago

My guess is that it might be based on corpses and that spacing deletes those.

realforest2001 commented 1 year ago

Checking the code, this is because code checks for a list of people who died, and then current living mobs. Having been deleted you don't count as either.