search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
96 stars 545 forks source link

Custom Incinerator fuel: Oxygen sometimes behaves oddly at different u/ts #5184

Open nuklearcellphoneg opened 10 months ago

nuklearcellphoneg commented 10 months ago

Testmerges

4842: '/tg/ Status Effects Part 2 - datum, KD, KO, Stuns' by fira at commit 6fa7d179f6 #5130: 'Armor Light Buff for Heavy/Medium/Leader armor' by Nanu308 at commit 0967f9b459 #5157: 'adds a medal viewer' by harryob at commit c7e273713a

Round ID

19897

Description of the bug

https://youtu.be/X8sUONx9-Q8?si=cWiWQdG9PZNsR45A

Oddity occurs once at :40

https://youtu.be/4QL1hHQejHw

Happened some more late on twice in a row- seems kinda random but maybe it's a rounding error or something with the amount of fuel left inside the canister.

What's the difference with what should have happened?

Shoulda been oxygen fire only

How do we reproduce this bug?

  1. Fill incin tanks with oxygen
  2. Cycle through the various u/t amounts
  3. Seemingly randomly it may put out regular incinerator fire ...

Issue Bingo

Huffie56 commented 10 months ago

i have no idea how liquid work on the floor on the floor but that seem that's what's causing the weirdness there....

first video i can see you fire upon a grease spot maybe you have heated up it enough that it then catch fire?

second video we clearly see you using you extinguisher (leaving water on the floor) that would explain why they extinguish faster then the two orange flame are weird could be chemical we can't see that you manage to light up like in first video...

nuklearcellphoneg commented 10 months ago

It seems random- I assume it's to do with X amount of fuel left in the canister if I had to guess or perhaps because I set it to 7 u/ts while the canister had 70%? While I can get it to repeat the oddity I can't consistently get it to repeat. AFAIK liquids on the ground are hard coded not to ignite- at least the last time I tried with welding fuel I couldn't.

Huffie56 commented 10 months ago

tested it out and could reproduce it by using a custom fuel tank m240a1 and filling it with oxygen after a few spray it made some red flames.. when i examine it on local that's what i got. image apparently it fire napalm at random when starting as oxygen.