search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
96 stars 545 forks source link

Air Supply Pipes, sprite discoloured/invisible #5617

Closed MistChristmas closed 8 months ago

MistChristmas commented 8 months ago

Testmerges

5086, #5392, #5007

Round ID

20667

Description of the bug

The Air supply pipes. Atleast those on the Alaymer. But I presume all of them are grey when they are wrenched in place. Instead of their usual blue. If they are wrenched and then wrenched back in. They turn invisible.

I would assume this potentially affects other pipes. But Air Supply pipes are by far the most common to observe this effect on.

EDIT: Uh they also turn into bent pipes for some reason. Presume this is a symptom of why they turn invisible when wrenched back in

What's the difference with what should have happened?

They should be blue when you look at them, and not invisible when you unwrench and wrench them back in.

How do we reproduce this bug?

  1. Observe/ Spawn as marine
  2. Find nearest pipe
  3. Wonder if you're colourblind
  4. Decide 'no, it must be server', I was already colourblind before they turned grey.
  5. Then unwrench and wrench it back in
  6. Notice it has now gotten worse as it's invisible ...

Issue Bingo

MistChristmas commented 8 months ago

Aaaaaa I forgot picture. New Bitmap image (2) As seen. They're not blue, and one's invisible after I wrenched and rewrenched it.

Also no I'm not crazy atleast two other people say they're grey and invisible. And I'm not using Beta Byond. I'm using: 514.1589

MistChristmas commented 8 months ago

Probably something to do with this #5553

Huffie56 commented 8 months ago

if nobody is doing a fix i will work on one in an hour.

MistChristmas commented 8 months ago

New Bitmap image (3) For some reason pipes turn into bent pipes after you unwrench them. Despite not originating from a bent pipe... I don't think the colours did that.

Huffie56 commented 8 months ago

New Bitmap image (3) For some reason pipes turn into bent pipes after you unwrench them. Despite not originating from a bent pipe... I don't think the colours did that.

i can see you have cable in your belt why is it white?

Huffie56 commented 8 months ago

seeing that i am revert my PR should fix it letting it open in case the bend pipe stay... https://github.com/cmss13-devs/cmss13/pull/5626

MistChristmas commented 8 months ago

i can see you have cable in your belt why is it white?

White is just one of the colours cable coil can be? I'm pretty sure it's just the colour it got giving, and not all cable coils are white... Though I don't play engi alot.

Drulikar commented 8 months ago

Resolved via https://github.com/cmss13-devs/cmss13/pull/5626

Any other issues like the unwrenching being the wrong state make that a separate issue if it still can occur.