cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
101 stars 565 forks source link

Girder finishing does not account for destruction of girder. #6435

Open cm13-issue-bot opened 5 months ago

cm13-issue-bot commented 5 months ago

Testmerges

#6071: '[V] Sorokyne Strata: fixes and changes .' by Venuska1117 at commit 77b1ffb107
#6304: 'STEEL DIVISON (Re-introduces 200 pop locked tank) [CODE BOUNTY]' by Red-byte3D at commit b51bd40abe
#6355: 'ID Mod computer biometrics' by realforest2001 at commit bd4cb15883
#6383: 'Replaces the ARC interior & ARC tweaks' by Zonespace27 at commit c9e49da969
#6363: 'First Drop Protections: Gas and Static Turrets' by Drulikar at commit bb9a7df8e2
#6388: 'gayons' by 567Turtle at commit 4f9151f1ba
#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 3db8a9a0e2
#6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 9f4c76c456
#6392: 'Adds in-game bug reports without needing a GitHub account' by vero5123 at commit 292f4f0efe

Round ID

22601

Description of the bug

If you weld to finish off a girder, and a xeno/bullets destroy it. The girder will still be finished in its final form.

What's the difference with what should have happened?

Should not go through. Girder should have to be repaired first, as epected.

How do we reproduce this bug?

1) Weld girder. 2) Girder destroyed.

  1. Girder is welded and wall is placed.

Report details

Author: AnonHault Admin: Piterskiy

ItsVyzo commented 2 months ago

I was told by Beagle the following:

it probably doesnt check if the girder actually exists anymore after the do_after