cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
95 stars 524 forks source link

Nuclear Authentication Disks reduce Nuclear Weapon decryption time. #6511

Closed blackdragonTOW closed 3 months ago

blackdragonTOW commented 3 months ago

About the pull request

Adds a simple 30% reduction in what ever decryption time is left when we use a Nuclear Authentication Disk on a nuke.

Note: Has no effect on the admin spawned nuke which does not have a decryption timer.

Explain why it's good for the game

Presently our maps have Nuclear Authentication Disks, and when found it's treated with some semblance of gravity, but in actuality they do nothing. This rewards finding such an important object and in the occasion that the disk is found and the End Game for the round is also a decryption nuke.

Testing Photographs and Procedure

Tested with all listed fail states contained within /obj/structure/machinery/nuclearbomb/tech/attackby()

Screenshots & Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags.

Changelog

:cl: add: Nuclear Authentication Disks now reduce remaining decryption time by 30%. /:cl:

vero5123 commented 3 months ago

lord, you need to do early returns man.

blackdragonTOW commented 3 months ago

lord, you need to do early returns man.

Yeahhhh, still learning, tried it another way that should be easier to read.

Steelpoint commented 3 months ago

Maybe the disk allows you to set a custom detonation timer? Instead of a flat 60 seconds, you can set it to detonate either instantly or up to several minutes slower than normal?

blackdragonTOW commented 3 months ago

Maybe the disk allows you to set a custom detonation timer? Instead of a flat 60 seconds, you can set it to detonate either instantly or up to several minutes slower than normal?

Likely would get shotdown faster than just the decrypt timer. Marines wont set it longer than 60s and making it shorter than 60s would be "unfair" according to our resident xeno experts.

Regardless changing this to making the reactors behave differently during SD is way off Theme for what this sets out to do so I'll just kill it here.