search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
95 stars 524 forks source link

Burrower burrow transparency #6550

Closed Unknownity closed 2 months ago

Unknownity commented 3 months ago

About the pull request

Burrower used to be completely invisible to the user when burrowed, this was suddenly changed some time ago (idk when, I was away) and made the Burrower completely visible as if he isnt underground.

This PR will bring back the immersion and improve it. Now the Burrower becomes partly transparent while burrowed as a visual indication that you did actually burrow and are currently underground.

Was tested, xenos and thermal equipment (pred masks, bug-b-gone goggles etc.) can still see their health/plasma/rank HUD as before (now just more transparently) and the burrower is still 100% invisible to humans.

Explain why it's good for the game

Improves immersion, fixes a bug (I assume it is considering I've found no PR linked to the change), makes Burrower mains struggle less if they actually burrowed or not

Testing Photographs and Procedure

Screenshots & Videos video of the "new" feature (actually a fix) in action: https://gachi.gay/u1Ik4

Changelog

:cl:Unknownity fix: Burrowers now see themselves as partly transparent when burrowed. /:cl:

TheManWithNoHands commented 3 months ago

If i remember rigth there should be a sprite around for the burrower halfway burried. Was for its old straint that was swiftly canned again. If your all about making it more immersive, migth be worth to look into that. Thougth that would be a LOT more work. Just fiy, if you want to dabble with it.

Unknownity commented 3 months ago

If i remember rigth there should be a sprite around for the burrower halfway burried. Was for its old straint that was swiftly canned again. If your all about making it more immersive, migth be worth to look into that. Thougth that would be a LOT more work. Just fiy, if you want to dabble with it.

Impaler looks different.

TheManWithNoHands commented 3 months ago

Impaler looks different.

Was just an note in case you didnt know

github-actions[bot] commented 2 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself