cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
82 stars 462 forks source link

In-view verbs work for varying view ranges #6591

Open Doubleumc opened 4 days ago

Doubleumc commented 4 days ago

About the pull request

Admin "InView" procs now take the user's current view range into account. If you zoom out as a ghost, it will use your current view size as you'd expect.

Where possible, admin and observer procs use a global list check instead of a view check. This prevents an issue where a right-clicked subject moves out of view before you can click on the menu option, which causes the option to fail and fill your command bar with some useless text.

Does not take view offsets into account, e.g. binoculars shifting client.pixel_x & client.pixel_y

Explain why it's good for the game

Procs billed as "in-view" should work based on your current view range. Right-click actions without a specific range cap should work on anything in your view range.

Testing Photographs and Procedure

Each proc continues to work as expected, just with more lenient ranging rules.

Changelog

:cl: qol: ghost health scan & follow right-click actions work at any range admin: "InView" procs use your current view range (e.g. ghost zoom) /:cl: