search

cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
82 stars 465 forks source link

Cannot Examine #6612

Closed cm13-issue-bot closed 3 days ago

cm13-issue-bot commented 5 days ago

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 18cfcab3cd
#6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345720
#6308: 'Hostile Survivor Rework' by Steelpoint at commit bf51f9e551
#6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 62d1be1e65
#6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit 86a7391c13
#6594: 'Ports "Adds a Chat Reliability Layer"' by Git-Nivrak at commit 7bd9347698
#6568: 'Chemical simulator TGUI' by kiVts at commit 97fc829599

Round ID

22917

Description of the bug

Due to recent test merges the ability to examine things on the action bar is disabled. However shift clicking still works.

What's the difference with what should have happened?

The command to examine pops up in the bottom right, however the actual examine function is not executed.

How do we reproduce this bug?

  1. Right click any item
  2. Click Examine

Attached logs

State: OPEN     Refresh

Opened at: 01:43:40 (Approx 3 minutes and 50.4 seconds ago)

Log:

01:51:57: DonOmet/(Austin Roe): Is examining glitched for you as well? When I attempt to the command to examin pops up in the bottom right but doesn't actually examine the item.
01:52:08: Ticket marked!
01:52:18: PM From Backsea: that was happening to me last round aswell, try shift clicking instead 
01:52:34: Reply PM from-DonOmet: Thanks! Is this a recentish bug?
01:53:18: PM From Backsea: seems so, report it please, new system makes it easy, ill approve it since this seems like a recouring issue
01:54:08: Reply PM from-DonOmet: Where's the report option in game? or would I have to do it in the forums?
01:54:24: PM From Backsea: top right on the screen, right next to discord and forum

Additional details

Releasethesea commented 5 days ago

after further testing it appears to only apply to items youre holding

Doubleumc commented 5 days ago

The issue is due to this recent change: https://github.com/cmss13-devs/cmss13/pull/6591/files#diff-574e8bc8332bd8c31272b0986d27302f529a6414a8011ae367b178a46284dc57L487-R487

Before, with view() (effectively view(usr)): Examine verb only visible on objects in-world & visible to the usr's mob, within default view range. Examine works on all these objects. The option to Examine interface items did not exist. If client's view range is longer than the default, Examine does not appear as an option on objects beyond that range.

After, with view(client) (effectively view(src.client)): Examine verb visible on any object the client can see out to the client's view range, including nullspace objects like interface buttons. Examine only works on in-world objects, and produces weird content in the command bar for nullspace objects and inventory items.

The way a verb's in view(...) works is super bespoke. I can't find a way for it to work with a user's dynamic view range and exclude interface items. Closest I can come is: