cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
95 stars 530 forks source link

Tutorial Abom Prevents Round End #6867

Closed cm13-issue-bot closed 2 months ago

cm13-issue-bot commented 2 months ago

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 8d2cc8fb83
#6071: '[V] Sorokyne Strata: Expanded Small corridors, removed 3000 unused tiles, allow LAZ for CAS inside most structures, Xenos can now weed everything except LZ's and surrounding of LZ's.' by Venuska1117 at commit 9d5e6d4658
#6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit 9c657a6ba3
#6712: 'Use DVIEW' by Doubleumc at commit f4b53dd614
#6692: 'Use RANGE_TURFS' by Doubleumc at commit 834383bfa0
#6682: 'Hugged changes' by zzzmike at commit 901f664a71
#6652: 'autoclimbable handrails on harm intent' by cuberound at commit 7952d21d5d
#6860: 'Mentor New Player Markers' by realforest2001 at commit 6dacc271a5
#6561: 'CRAWLING !!!!' by Diegoflores31 at commit 902c0ffa09
#5876: 'remote dropship computers are no longer hard coded to dropship id' by mullenpaul at commit cd66420484

Round ID

23351

Description of the bug

As the name says, if someone is in the tutorial as an abomination then the round cannot end if all other Xenos are dead.

What's the difference with what should have happened?

If all Xenos are dead, the round should end.

How do we reproduce this bug?

  1. Enter abom tutorial
  2. Kill all bugs
  3. Round doesn't end

Attached logs

N/A

Additional details

Git-Nivrak commented 2 months ago

Couldn't reproduce

Drulikar commented 2 months ago

The abom is part of the tutorial hive, and the tutorial hive returns false for /datum/hive_status/tutorial/can_delay_round_end(mob/living/carbon/xenomorph/xeno) so there should be no delay. You maybe just confused the timer that occurs on round end that is only sent to command so they can finish up medals or whatever before the serve wide announcement of round end. image

If you are able to provide a reproduction though feel free to make another report