cmss13-devs / cmss13

Contains the code for CM-SS13
https://cm-ss13.com
GNU Affero General Public License v3.0
95 stars 528 forks source link

Hugger Leap Ability Not Working Properly #7274

Open cm13-issue-bot opened 21 hours ago

cm13-issue-bot commented 21 hours ago

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 22dcde564c
#6808: 'Attachments resprite' by Blundir at commit cc4fe40905
#6938: 'SHARP Rifle Revived' by Nomoresolvalou at commit 744d618abd
#7231: 'fix for pred round chance and the database' by harryob at commit eb7ba1cb20
#7242: 'WIP Yautja Clan TGUI Menu' by realforest2001 at commit c03f515dfb
#7023: 'Research Rework Part Two: The Contract System.' by kiVts at commit 338e73f0c1
#6860: 'Mentor New Player Markers' by realforest2001 at commit 1457cbadfe
#7110: 'Refactors launching into a subsystem' by boskoramen at commit b614428c7e

Round ID

24236

Description of the bug

Using your Leap ability as a hugger does not knock down targets nor hug them, and instead causes you to simply move to the targeted tile while floating in the Leap animation for an extended period of time.

What's the difference with what should have happened?

When using Leap and hitting a marine, it should knock them prone momentarily, or hug them if they are adjacent. The Leap animation should also only play for a split-second while you're in flight.

How do we reproduce this bug?

1) Spawn as Facehugger and enable your Leap ability 2a) Leap at any empty square and notice that you hang in the air in the Leap animation for an extended amount of time 2b) Leap at a Marine at a long distance and they will not be knocked down 2c) Leap at a Marine at an adjacent tile and they will not be knocked down nor hugged.

Attached logs

N/A

Additional details

SweaterKittens commented 20 hours ago

I published this from in-game but wanted to add on.

It appears that the issues here are there, but also inconsistent. I was able to get hugs from adjacent tiles sometimes, and was able to knock down a person with a ranged leap one time. So it isn't completely broken, but there is something wrong.

HaultyAnonie commented 20 hours ago

7273

boskoramen commented 7 hours ago

Fixed here: https://github.com/cmss13-devs/cmss13/pull/7110/commits/7d3e548f201e89e83e46fb29694fe6e8e546a525