search

cmswalker / fullpage-react

Stateful fullpage.js inspired scrolling for React
https://cmswalker.github.io/fullpage-react/
206 stars 42 forks source link

Compatibility with fullpage.js #90

Closed cmswalker closed 6 years ago

cmswalker commented 6 years ago

Continuing discussion + RFC for https://github.com/cmswalker/fullpage-react/issues/83

fullpage.js V3 is on the horizon and will lose it's jquery dependency. This library should reduce itself to becoming a wrapper for that lib in order to consolidate communities and functionality. There are 3 steps we do to make this work.

  1. Publish all remaining patches for the current status of fullpage-react and release a patch version to NPM
  2. Finalize/Test and publish the fullpage.js react wrapper component https://github.com/cmswalker/fullpage-react/pull/89 and release a major version to NPM. This will add a jquery dependency to be compatible with the current version of fullpage.js
  3. Once fullpage.js V3 is out, remove the jquery dependency, test and publish a new major version to NPM.
  4. See if fullpage.js will maintain it's own react-wrapper component. If so, this lib can be deprecated in favor of the official one.

I'll add a migration path for those on the current release for fullpage-react to migrate to the fullpage.js backed one. As well as descriptions of the 3 working versions and their dependencies.

cmswalker commented 6 years ago

Update: Thanks to @robbiew I'm currently in the process of getting this library wrapped into official fullpage.js. Will update this repo accordingly when it is finished (very soon)

cmswalker commented 6 years ago

This has now been moved! There are some API level changes but markup remains largely the same

Under the new project all fullpage.js APIs are available for the react component