search

cmtjk / LinkUpConnect

15 stars 1 forks source link

Confirmation of terms #6

Open infossk opened 1 year ago

infossk commented 1 year ago

Hi, your solution stopped working last night. I found that Abbott was doing maintenance and needed to re-confirm the terms of use before logging into the LibreLink account using the LibreLinkUp app login. Isn't it somehow possible to solve this situation in the future with automatic confirmation? Well thank you.

cmtjk commented 1 year ago

Technically this might be possible but requires further analyzation. I'll have to have a look at it. But to be honest I'm not a fan of it and I'm quite sure this is a TOS violation.

I'll label as wontfix but keep it open if someone else is interested in this feature. PRs welcome.

infossk commented 1 year ago

Technically this might be possible but requires further analyzation. I'll have to have a look at it. But to be honest I'm not a fan of it and I'm quite sure this is a TOS violation.

I'll label as wontfix but keep it open if someone else is interested in this feature. PRs welcome.

I understand. In such a case, it would perhaps be appropriate that if this state occurs, so that the user is notified that he should use the official application to approve the relevant documents, so he knows where the problem is when it stops working. Maybe it would be enough if it was in the debug information.

cmtjk commented 1 year ago

Good point. I'll check whether I can somehow make my account have to accept the TOS again and check the payload.

If someone else does not yet have accepted the TOS I'll appreciate posting the debug log here.

cmtjk commented 1 year ago

@infossk where did you had to accept the new TOS? LibreLinkUp app or Libre 3/LibreLink app?

We can do something like this: grafik

Unfortunately, I can't really validate the TOS thing but I think it's covered by the new message which will pop up if no data was received. I'll make a pre-release available to test it, since I want to make sure the alert does not pop up randomly when there's a short-term issue fetching the data.

cmtjk commented 1 year ago

https://github.com/cmtjk/LinkUpConnect/releases/tag/v1.3.4-beta.1