search

cmtrounce / SwURL

Lightweight and customisable async image loading in SwiftUI. Supports on-disk storage, placeholders and more!
MIT License
203 stars 17 forks source link

Updated to support Xcode 11.0 beta 4 #3

Closed JS1010111 closed 5 years ago

JS1010111 commented 5 years ago

Minor changes to compile with Xcode 11.0 beta 4 without errors/warnings.

cmtrounce commented 5 years ago

@JS1010111 what's the best way to get in touch with you? slack or discord?

JS1010111 commented 5 years ago

Hi @cmtrounce , This PR was good for beta 4, I tested it on a project and it worked without any issues. However, it probably has warnings on beta 5 released yesterday (I didn't have the chance to check it yet).

The didChange was deprecated and we should call willChange on willSet (before actually making the changes). Apple has some new diffing APIs and they say this way things are faster.

In beta 5 there are protocol changes and a new property wrapper @Published:

ObservableObject automatically synthesizes objectWillChange and emits before any @Published properties change.

Take a look at SwiftUI changes on the beta 5 release notes: https://developer.apple.com/documentation/ios_ipados_release_notes/ios_ipados_13_beta_5_release_notes

Sorry I'm not currently using Slack or Discord.

cmtrounce commented 5 years ago

Hi @JS1010111 ,

just to let you know, im in the process of setting up Travis CI so that pull requests, and branches can be tested / built automatically.

If it will allow you to, could you please branch from my repository rather than using your own fork?

Many Thanks,

Kind Regards