Pedro ac2 - Githubissues

cmu-argus-2 / GNC-Simulation

1 stars 1 forks source link

Pedro ac2 #37

Closed prchall123 closed 5 days ago

prchall123 commented 1 week ago

Added sun pointing and detumbling controllers.
Fixed attitude kynematics bug
Added plots to post-processing
Added sun position and magnetic field to state vector

Herpderk commented 1 week ago

In general, there should be more type hinting and maybe even a README describing the methods that the sim directly interfaces with. I also advocate for a class attribute naming convention that distinguishes "public" from "private" members and properties--e.g. object.public_member v.s. object._private_member.

prchall123 commented 6 days ago

All comments have been addressed to the extent I'm able to deal with them. @kmkar31 I'd ask you to review if youre happy with the current version.