search

cmu-cs-academy / desktop-cmu-graphics

BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

Require users to call cmu_graphics.run() #20

Closed austin-schick closed 2 years ago

austin-schick commented 2 years ago

Replaces cmu_graphics.loop() with cmu_graphics.run() Doesn't attempt to automatically run the mainloop for a user's app Fixes the issue where an interactive console would be created even when an error happened before cmu_graphics.loop() was called Prints a help message when shapes are created by cmu_graphics.run() was never called

austin-schick commented 2 years ago

I think we should check in with the fulltimers to see what they think about loop vs run vs runApp vs something else

schmave commented 2 years ago

Since it looks like we're going with .run(), you could update the README too

austin-schick commented 2 years ago

@schmave I think this is ready for another look. The build is failing, but only because of a weird segfault in the Python3.7 pip tests