search

cmu-cs-academy / desktop-cmu-graphics

BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Update __init__.py #71

Closed Mohamed-Waiel-Shikfa closed 3 months ago

Mohamed-Waiel-Shikfa commented 3 months ago

Tries to address:

changing this line like the error suggested seems to work by my tests. If this might cause some issues I am not aware of please let me know (with some quick explanation :) .

Mohamed-Waiel-Shikfa commented 3 months ago

I think this new solution is optimal as it makes things "just work" the way you'd expect in all scenarios. If you have any comments, please let me know, otherwise I think this is ready to be merged.

austin-schick commented 3 months ago

Thanks for doing some work on this!

Mohamed-Waiel-Shikfa commented 3 months ago

You're welcome! My pleasure. I have made all the suggested changes.