CSA-1189 Add Rotate method for shapes and the corresponding test

cmu-cs-academy / desktop-cmu-graphics

BSD 3-Clause "New" or "Revised" License

15 stars 9 forks source link

Closed Yuxiang-Huang closed 2 months ago

Yuxiang-Huang commented 2 months ago

Now there is a rotate function for shape! Check http://localhost:3000/docs/generalShapeMethods for documentation. Also add rotate_method.py test in test-image-gen.

Mohamed-Waiel-Shikfa commented 2 months ago

Thanks for that work. I have a few comments:

Both your links don't work for me. Could you confirm they work for you and if yes instruct me on how to get them working for me
Did you change the online documentation? how so? this might be useful information for futur contributors.
Why did you go with degrees, cx, cy? I feel like cx, cy, degrees would be more consistent with how things usually work in cmu_graphics(referencing arcs). It's also the way you used it in your tests...

schmave commented 2 months ago

Sorry, the links in the PR description are related to our non-open-source code, so that's why you can't access them.

We did update the documentation to include a mention of rotate, but it hasn't been deployed yet. You'll be able to see it here by 12am UTC 7/11.