cmu-db / 15445-bootcamp

A basic introduction to coding in modern C++.
Apache License 2.0
721 stars 142 forks source link

fix: return a reference to the DLLIterator when overloading a pre-increment operator #3

Closed Nateiru closed 11 months ago

Nateiru commented 1 year ago

I notice that DLLIterator overloads the pre-increment operator without returning a reference.

Although there is a post here that says this is not necessary, common implementation will return a reference when overloading a pre-increment operator, which is also mentioned in cppreference.

BTW I'm OK if you ignore this PR and just make the edits yourself as you see fit.

Finally, thank you for putting together this repo. I think many will find it helpful.