search

cmu-db / 15445-bootcamp

A basic introduction to coding in modern C++.
Apache License 2.0
721 stars 142 forks source link

fix: mistake and typo in comments #9

Closed Aniurm closed 11 months ago

Aniurm commented 1 year ago

in src/shared_ptr.cpp

There are some typos in comments.

After modify_ptr_via_rvalue_ref(std::move(s2));, s2 should have y = 645

skyzh commented 11 months ago

after further looking into this example, it does not seem valid? clang-tidy should complain that s2 being used after std::move... probably we will fix this example in future semesters without merging this pull request. anyways, thanks for the contribution!

abigalekim commented 11 months ago

all these things are right, ty for typo fix (although I was rereading these bc i was sick and then noticed them so then i think i fixed most of these errors)