Executor: Incorrect description of AggregationExecutor::Next()

cmu-db / bustub

The BusTub Relational Database Management System (Educational)

https://15445.courses.cs.cmu.edu

MIT License

4.12k stars 1.81k forks source link

Executor: Incorrect description of AggregationExecutor::Next() #476

Closed yfhu99 closed 2 years ago

yfhu99 commented 2 years ago

In file src/include/execution/executors/aggregation_executor.h:

/**
 * Yield the next tuple from the insert.
 * @param[out] tuple The next tuple produced by the insert
 * @param[out] rid The next tuple RID produced by the insert
 * @return `true` if a tuple was produced, `false` if there are no more tuples
 */
auto Next(Tuple *tuple, RID *rid) -> bool override;

skyzh commented 2 years ago

Would you please send a PR to fix that?