search

cmu-db / bustub

The BusTub Relational Database Management System (Educational)
https://15445.courses.cs.cmu.edu
MIT License
4.12k stars 1.81k forks source link

fix(interface): modified ExtendibleHashTable::Insert() return type #487

Closed AkiyamaKunka closed 1 year ago

AkiyamaKunka commented 2 years ago

From CMU 15-445 2022 fall Project Webpage, ExtendibleHash::Insert() method need return a bool type instead of void.

image
odysa commented 2 years ago

Could you please also update the comment? https://github.com/cmu-db/bustub/blob/25f8d91fbc602f956928be36ed26ef420b2bd42a/src/include/container/hash/extendible_hash_table.h#L84-L95

skyzh commented 2 years ago

I guess this will affect existing projects for this semester. Postpone merging to next semester. LGTM, thanks!

AkiyamaKunka commented 2 years ago

I guess this will affect existing projects for this semester. Postpone merging to next semester. LGTM, thanks! Appreciate it~

skyzh commented 1 year ago

fixed with https://github.com/cmu-db/bustub/pull/524