search

cmu-db / bustub

The BusTub Relational Database Management System (Educational)
https://15445.courses.cs.cmu.edu
MIT License
4.12k stars 1.81k forks source link

bug: incorrect return type for ExtendibleHTableHeaderPage::GetDirectoryPageId #625

Closed kenleung5e28 closed 3 months ago

kenleung5e28 commented 1 year ago

The signature for ExtendibleHTableHeaderPage::GetDirectoryPageId is:

auto GetDirectoryPageId(uint32_t directory_idx) const -> uint32_t;

Judging from the intent for this method, its return type should be page_id_t instead.

lidianzhong commented 1 year ago

I think so, page_id_t type should be returned