cmu-db / bustub

The BusTub Relational Database Management System (Educational)
https://15445.courses.cs.cmu.edu/
MIT License
3.92k stars 1.76k forks source link

proposal: update prompt message of `build_support/packages.sh` #672

Closed mooxiu closed 8 months ago

mooxiu commented 8 months ago

When preparing building the project and execute build_support/packages.sh, the prompt message will be: Proceed? [Y/n] :

The default behavior (when pressing enter/return without inputting y or n) is do nothing, however, the common practice is that the default behavior should be the same with the capitalized option (in this case, Y). If someone assume default behavior to be yes, then it might lead to lack of necessary packages, which is really confusing.

My proposal, change this line from:

        read -p "Proceed? [Y/n] : " yn

to:

        read -p "Proceed? [y/N] : " yn
skyzh commented 8 months ago

feel free to submit a pull request